-
Notifications
You must be signed in to change notification settings - Fork 349
Made callbacks optional for async functions #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed it to a draft, hadn't run tests or linting myself yet. Need to clean this up a bit first. |
There we go. Addressed any linting issues and updated the tests. |
@lobabob when you get a chance, can you fix up the formatting, otherwise, I think this should be good to go. |
Went ahead and addressed the formatting issue. Forgot to remove the unused promisify import earlier 😅 |
Hmmm.... Looks like these changes have exposed some type issues in your tests that were swallowed by promisify before. |
Looks like everything is passing. You should be good to merge it unless you see any other issues with it. |
Nope, this looks good, appreciate your work on it! |
Do you know when a new version is gonna be pushed up so I can get these changes? Not sure if there's a better place to ask this, so I figured I'd just ask it here since these are the changes in question. |
Just published in v8.1.0 |
For #429