+
Skip to content

Conversation

lobabob
Copy link
Contributor

@lobabob lobabob commented May 2, 2025

For #429

@lobabob lobabob changed the title Made callbacks optional for async functions. #429 Made callbacks optional for async functions May 2, 2025
@lobabob lobabob changed the title Made callbacks optional for async functions Draft: Made callbacks optional for async functions May 2, 2025
@lobabob
Copy link
Contributor Author

lobabob commented May 2, 2025

Changed it to a draft, hadn't run tests or linting myself yet. Need to clean this up a bit first.

@lobabob lobabob changed the title Draft: Made callbacks optional for async functions Made callbacks optional for async functions May 2, 2025
@lobabob
Copy link
Contributor Author

lobabob commented May 2, 2025

There we go. Addressed any linting issues and updated the tests.

@wavded
Copy link
Collaborator

wavded commented May 7, 2025

@lobabob when you get a chance, can you fix up the formatting, otherwise, I think this should be good to go.

@lobabob
Copy link
Contributor Author

lobabob commented May 7, 2025

Went ahead and addressed the formatting issue. Forgot to remove the unused promisify import earlier 😅

@lobabob
Copy link
Contributor Author

lobabob commented May 7, 2025

Hmmm.... Looks like these changes have exposed some type issues in your tests that were swallowed by promisify before.

@lobabob
Copy link
Contributor Author

lobabob commented May 9, 2025

Looks like everything is passing. You should be good to merge it unless you see any other issues with it.

@wavded wavded self-assigned this May 9, 2025
@wavded wavded merged commit 85a2947 into tj:master May 9, 2025
3 checks passed
@wavded
Copy link
Collaborator

wavded commented May 9, 2025

Nope, this looks good, appreciate your work on it!

@lobabob
Copy link
Contributor Author

lobabob commented May 17, 2025

Do you know when a new version is gonna be pushed up so I can get these changes? Not sure if there's a better place to ask this, so I figured I'd just ask it here since these are the changes in question.

@wavded
Copy link
Collaborator

wavded commented May 19, 2025

Just published in v8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载