Add some basic documentation on notifications #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll keep this on-hold while we continue work on the push notifications. Once the push notifications are at a stable stage, I'll add some additional context if necessary merge this in! |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds some very basic documentation for notifications. You can see there are several TODOs that we need to flesh out, specifically with regards to self-hosting. But I wanted to get something out there to start. I think eventually we can link to this page from directly in Thunder (or even load up the contents and render it).
BTW, so far, I haven't found a way to request a specific endpoint from the UnifiedPush connector package. Therefore, I'm documenting how to use a custom server with ntfy by setting it up in the app first.