renderer: revise canvas context handling in target method #3773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a deadlock issue in the ThorVG renderer by modifying the status checking logic in canvas target methods. The change prevents the WG engine's target() method from returning early during the initialization phase when the status is Painting, which previously caused context initialization to be skipped and led to deadlocks in subsequent render operations.
- Updated status validation logic in
target()methods for SwCanvas, GlCanvas, and WgCanvas - Changed from allowing
DamagedandSyncedstatuses to only allowingUpdatingandDrawingstatuses - Prevents early return during initialization phase that was causing unset context issues
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hermet
requested changes
Sep 2, 2025
There was a problem hiding this comment.
- please check copilot comment,
||is correct. - Please update the title — there is no deadlock issue in ThorVG itself. The deadlock is entirely due to the WASM binding, caused by a naughty implementation of context handling. You've now revised the concept of the canvas context, so the title should be updated accordingly.
b3ceae5 to
088fe9f
Compare
This update refines the management of the canvas context during initialization and operation. By improving context handling, it resolves a potential issue where the target method might not function correctly in certain cases.
088fe9f to
1373e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update refines the management of the canvas context during initialization and operation. By improving context handling, it resolves a potential issue where the target method might not function correctly in certain cases.
related: #3763