gl_engine: remove level parameter from blur #3626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
level parameter removed from blur and dropshadows shaders. data structures alligment keeped
de1b565 to
f9b61d5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated level parameter from the Gaussian blur and drop shadow shaders and the associated C++ effect code, replacing it with a dummy padding value to preserve std140 alignment.
- Remove
int levelfrom all shader uniform blocks and adddummy0as padding - Delete
GL_GAUSSIAN_MAX_LEVELdefine and relatedlevelassignments in C++ - Add
float dummy0toGlGaussianBlurstruct for memory layout consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/renderer/gl_engine/tvgGlShaderSrc.cpp | Removed level in three uniform blocks and inserted dummy0 padding |
| src/renderer/gl_engine/tvgGlEffect.cpp | Deleted GL_GAUSSIAN_MAX_LEVEL and level assignments; added dummy0 to GlGaussianBlur |
Comments suppressed due to low confidence (4)
src/renderer/gl_engine/tvgGlShaderSrc.cpp:746
- [nitpick] The placeholder member
dummy0is ambiguous. Consider renaming it topadding0orpad0and adding a comment explaining it’s used to maintain std140 alignment after removinglevel.
float dummy0;
src/renderer/gl_engine/tvgGlShaderSrc.cpp:782
- [nitpick] The placeholder member
dummy0is ambiguous. Consider renaming it topadding0orpad0and adding a comment explaining it’s used to maintain std140 alignment after removinglevel.
float dummy0;
src/renderer/gl_engine/tvgGlShaderSrc.cpp:819
- [nitpick] The placeholder member
dummy0is ambiguous. Consider renaming it topadding0orpad0and adding a comment explaining it’s used to maintain std140 alignment after removinglevel.
float dummy0;
src/renderer/gl_engine/tvgGlEffect.cpp:39
- [nitpick] The member
dummy0inGlGaussianBluris ambiguous. Rename topadding0orpad0and document that it preserves the struct’s std140 layout after removinglevel.
float dummy0{};
hermet
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
level parameter removed from blur and dropshadows shaders.
data structures alligment keeped