sw_engine: rectified softlight blending equation #3612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slightly adjusted the equation for adobe/figma alignment
There was a problem hiding this comment.
Pull Request Overview
Aligned the soft-light blending formula with Adobe/Figma by adjusting the clamp and multiplication order.
- Updated the formula comment to reflect the new term
(2 * s * d) - Changed the second term to clamp after
MULTIPLY(Cn(s), o.<channel>)instead of before multiplying byo.<channel>
Comments suppressed due to low confidence (1)
src/renderer/sw_engine/tvgSwCommon.h:564
- Add unit tests covering boundary cases (e.g., s = 127, 128 and d = 0, 255) to verify the updated soft-light blend matches the expected Adobe/Figma results.
auto c1 = MULTIPLY(255 - std::min(255, 2 * C1(s)), MULTIPLY(o.r, o.r)) + std::min(255, 2 * MULTIPLY(C1(s), o.r));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slightly adjusted the equation for adobe/figma alignment