sw_engine: improved the dropshadow effect support #3618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6ddf3d to
52630bb
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances drop shadow support by correctly rendering shadows when blur (sigma) is zero and ensuring the shadow offset scales with the render transform.
- Introduces a direct shadow rendering path (
_dropShadowDirect) used whensigma == 0. - Refactors pointer shifting into a new
_shifthelper for both blurred and direct shadows. - Applies the
scalefactor to the shadow distance offset.
Comments suppressed due to low confidence (2)
src/renderer/sw_engine/tvgSwPostEffect.cpp:269
- [nitpick] The helper name
_shiftis quite generic. Consider renaming it to something more descriptive like_shiftRegionor_applyOffsetShiftto clarify its purpose.
static void _shift(uint32_t** dst, uint32_t** src, int dstride, int sstride, int wmax, int hmax, const RenderRegion& bbox, const SwPoint& offset, int32_t* ow, int32_t* oh)
src/renderer/sw_engine/tvgSwPostEffect.cpp:421
- The new direct-shadow code path for
sigma == 0should be covered by unit tests to verify correct rendering without blur and ensure no regressions in future changes.
if (params->sigma == 0.0f) {
- shadow rendering was skipped when the blur value was 0. it now correctly renders shadows without blur. - this also fixes the distance offset scalability. issue: #3602
52630bb to
e7cc6e2
Compare
The direct raster version has been restored with a proper fix for the out-of-range bug. see history: 78753ee
8c16289 to
090a118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shadow rendering was skipped when the blur value was 0. it now correctly renders shadows without blur.
this also fixes the distance offset scalability.
issue: #3602