svg: fix nested use nodes #3616
Merged
+69
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
9615549 to
8812667
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes support for nested <use> nodes in SVG parsing by implementing recursive resolution of href references. Previously, only single-level <use> references were supported, causing rendering issues when a <use> node referenced another element that itself contained <use> nodes.
Key changes:
- Replaced Array-based postponed element tracking with an Inlist for better traversal control
- Added recursive checking to prevent cloning nodes with unresolved dependencies
- Implemented proper memory management for the new list-based approach
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/loaders/svg/tvgSvgLoaderCommon.h | Updated SvgNodeIdPair structure and changed cloneNodes from Array to Inlist |
| src/loaders/svg/tvgSvgLoader.cpp | Added recursive dependency checking and updated postponed node processing logic |
hermet
reviewed
Jul 15, 2025
JSUYA
reviewed
Jul 16, 2025
05b06fa to
bc0bf97
Compare
hermet
approved these changes
Jul 18, 2025
Previously, only single-level <use> references were supported. If a <use> node pointed to another element that itself contained a <use> node, the reference wasn’t resolved. This has been fixed by replacing the array of postponed elements with a list. The list is traversed, and nodes aren’t cloned while they or any of their children remain unresolved. In such cases, the target element also gets added to the list, enabling recursive resolution of nested href references. issue: #3615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only single-level references were supported. If a node pointed to another element that itself contained a node, the reference wasn’t resolved.
This has been fixed by replacing the array of postponed elements with a list. The list is traversed, and nodes aren’t cloned while they or any of their children remain unresolved. In such cases, the target element also gets added to the list, enabling recursive resolution of nested href references.
@issue: #3615
samples:
Archiwum.zip
before:
after:
