wg_engine: tesselletor optimization #3576
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SergeyLebedkin
commented
Jun 25, 2025
- invoid intermediate outline buffers for tessellation
- render shape and strokes by single draw call
1. invoid intermediate outline buffers for tessellation 2. render shape and strokes by single draw call
There was a problem hiding this comment.
Pull Request Overview
This PR introduces optimizations in the wg_engine tessellator by avoiding the use of intermediate outline buffers and consolidating the rendering of shapes and strokes into a single draw call. Key changes include the addition of new tessellator classes and associated logic in tvgWgTessellator.{h,cpp}, updates to renderer and render data modules to remove obsolete buffer pool usage, and corresponding adjustments in GL engine files and build configuration.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/wg_engine/tvgWgTessellator.{h,cpp} | New tessellator classes and optimized stroke/dash processing |
| src/renderer/wg_engine/tvgWgRenderer.{h,cpp} | Removed mBufferPool usage and updated updateMeshes calls |
| src/renderer/wg_engine/tvgWgRenderData.{h,cpp} | Consolidated mesh variables (meshShape, meshStrokes, etc.) and removed deprecated mesh group usage |
| src/renderer/wg_engine/tvgWgGeometry.{h,cpp} | Simplified geometry helpers and introduced clear() for mesh data |
| src/renderer/gl_engine/* | Updated scaling and transformation logic for GL tessellation and rendering |
| src/renderer/wg_engine/tvgWgCommon.{h,cpp} | Removed unused bufferIndexFan allocation |
| src/renderer/wg_engine/meson.build | Added new tessellator source file |
Comments suppressed due to low confidence (1)
src/renderer/wg_engine/tvgWgTessellator.cpp:38
- Consider using scaling(mMatrix) for both the numerator and denominator in the stroke width computation to account for rotation and non-uniform scaling, instead of dividing by mMatrix.e11 directly.
if (isinf(mMatrix.e11)) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.