action: auto-sanitize default or error on invalid user-defined hostname #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oxtoacart could this be the cause of the build failures on #194? i got a very similar error on the build for #195 and on this PR the TS client is still v1.82.0 |
mpminardi
approved these changes
Sep 23, 2025
Would be very suspicious that this is indeed what is causing the issues there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192
The issue is not affecting all runners. I was only able to reproduce the issue on MacOS runners.
This PR addresses 2 different scenario wrt the hostname the GH workflows use when joining a tailnet:
To address the 1st point we proactively sanitize internally generated hostnames to make them valid DNS labels. Example of a hostname that was proactively sanitized on a MacOS runner:
To address the 2nd point, we validate the hostname input is a valid DNS label and fail early with a clear error message if not: