+
Skip to content

Conversation

luciano-alexandre
Copy link
Contributor

@luciano-alexandre luciano-alexandre commented May 15, 2025

This commit introduces three new Tainacan data mappers to support integration with the INBCM (National Inventory of Cultural Museum Collections) system. The added mappers are:

ArchivalMapper – for handling archival data structures.

BibliographicMapper – for mapping bibliographic records.

MuseologicalMapper – for processing museological collection data.

These mappers facilitate the structured export of collection items in formats compatible with INBCM requirements.

Closes #953.

@mateuswetah
Copy link
Member

mateuswetah commented May 15, 2025

@luciano-alexandre thank you so much for you first contribution! 🎉

Overall things look good for me here. I have three considerations:

  • Class names should probably have 'INBCM' such as INBCM_Archival Because we're not sure if in the future more generic exporters will arise and it would help keep parity with the slug name.
  • The metadata labels are translatable but their default string is in Portuguese. While INBCM will mostly be used only by Brazilians, the plugin default language is English. As soon as we release the new version, we can rush to https://translate.wordpress.org/projects/wp-plugins/tainacan/ and make sure all strings are available in Portuguese. But keeping in English the original source is important for helping the translators job and also prevents a situation where some English user actually wishes to translate it and have no option for that.
  • Contradictory to the topic before I would say maybe the Mapper name should be kept in Portuguese (INBCM Arquivístico). Because that string on the other hand is not translatable. So we might wanna keep it in the language that will be more used and that makes more sense to anyone who knows the standard. Would you agree with that @vnmedeiros?

@luciano-alexandre
Copy link
Contributor Author

@mateuswetah Changes made

@luciano-alexandre
Copy link
Contributor Author

@vnmedeiros Changes made.

@mateuswetah mateuswetah merged commit d3d1c0d into tainacan:develop May 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

INBCM Mappers

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载