This repository was archived by the owner on Aug 23, 2022. It is now read-only.
adding filter function #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nuritizra it'd be cool to have this documented in the main repo example; https://github.com/spotify/comet#example, is that something you can add? |
|
Could you also add tests? |
…et-core into alpha_customers_onboarding
|
hi, added filter documentation in the example, but I don't have permissions to merge: |
jagheterfredrik
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a filter function to sources to filter out messages before saving to the db. (this will allow us to only send to alpha customers).
looking for a +1 so that we can deploy this version internally, but don't need this to be merged to master.