This repository was archived by the owner on Feb 21, 2023. It is now read-only.
Use strings.TrimFunc instead of strings.Trim. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is just a wrapper around the former, but creating a function on every call, which requires a memory allocation.
|
Benchmarks confirm increased performance, thanks! |
sorcix
pushed a commit
that referenced
this pull request
Jan 30, 2015
Use strings.TrimFunc instead of strings.Trim.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter is just a wrapper around the former, but creating a function
on every call, which requires a memory allocation.