+
Skip to content

fix: fix nested struct index #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

fix: fix nested struct index #1

merged 1 commit into from
Dec 5, 2022

Conversation

agtabesh
Copy link
Contributor

@agtabesh agtabesh commented Sep 5, 2022

There is a bug in encoding nested struct index which has been fixed on this pull request.

sonh
sonh approved these changes Dec 5, 2022
View reviewed changes
Copy link
Owner

@sonh sonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delay in replying to you 🙏
Yes, you are right, there is an issue with encoding nested struct index.
Nice catch, thanks you for this fix 🎉

@sonh sonh merged commit ea61bea into sonh:main Dec 5, 2022
@sonh sonh added bug Something isn't working good first issue Good for newcomers labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonh sonh sonh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agtabesh @sonh
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载