-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ENH] Fixed get_test_params for ColumnEnsembleClassifier #8916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENH] Fixed get_test_params for ColumnEnsembleClassifier #8916
Conversation
I think as always I have chosen the wrong one...
getting the error: is there any example where I can fix this correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you kindly leave the parameter ste for "results_comparison"
and only add parameters for the second part?
I see this is not mentioned in the issue, I will add this information.
I applied your changes but I think I need to do something with
I need to somehow add a |
The reason maybe that This might be an unreported bug. The general requirement is that no parameter that was set by |
If you can give me a bit more details on how to fix it, I'll try. |
Reference Issues/PRs
#3429
What does this implement/fix? Explain your changes.
Added a second dict as return for
get_test_params
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
The the new test parameter make sense.
Did you add any tests for the change?
Partially, new test parameters
PR checklist
For all contributions