+
Skip to content

Conversation

Abelarm
Copy link
Contributor

@Abelarm Abelarm commented Oct 5, 2025

Reference Issues/PRs

#3429

What does this implement/fix? Explain your changes.

Added a second dict as return for get_test_params

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

The the new test parameter make sense.

Did you add any tests for the change?

Partially, new test parameters

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

@Abelarm
Copy link
Contributor Author

Abelarm commented Oct 5, 2025

I think as always I have chosen the wrong one...
I wanted to add another test parameter where the remainder was
Kind of "easy":

param1 = {"estimators": [("cBOSS", cboss, 5), ("CIF", cif, [3, 
param2 = {**param1, "remainder": "passthrough"}

getting the error:
AssertionError: get_params result of ColumnEnsembleClassifier (x) does not match what was passed to set_params (y)

is there any example where I can fix this correctly?

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you kindly leave the parameter ste for "results_comparison" and only add parameters for the second part?

I see this is not mentioned in the issue, I will add this information.

@Abelarm Abelarm requested a review from fkiraly October 8, 2025 07:36
@Abelarm
Copy link
Contributor Author

Abelarm commented Oct 8, 2025

I applied your changes but I think I need to do something with set_param because I still get the error:

get_params result of ColumnEnsembleClassifier (x) does not match what was passed to set_params (y). Reason for discrepancy: [remainder].len, x.len = 4 != y.len = 11

I need to somehow add a set_params when I pass the "remainder": "passthrough" but I am not able to localize it.

@fkiraly
Copy link
Collaborator

fkiraly commented Oct 9, 2025

The reason maybe that remainder is not correctly set or gets overwritten?

This might be an unreported bug.

The general requirement is that no parameter that was set by __init__ and is of same name as the init args should ever change over the object lifetime.

@Abelarm
Copy link
Contributor Author

Abelarm commented Oct 9, 2025

The reason maybe that remainder is not correctly set or gets overwritten?

This might be an unreported bug.

The general requirement is that no parameter that was set by __init__ and is of same name as the init args should ever change over the object lifetime.

If you can give me a bit more details on how to fix it, I'll try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载