-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ENH] Move FCNClassifier test skip rule to estimator tag #8603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f631c57
to
7f843c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I think you missed an instance of FCNClassifier
in _config
though - please go through the recipe and check again.
@sinemkilicdere I believe @fkiraly is referring to these lines in the config (line 51 and 54) sktime/sktime/tests/_config.py Lines 51 to 54 in 9a647b3
|
Thanks Damir. working on now |
thanks for review. Issues have been resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think there should also be a tests:skip_by_name
tag which is missing. I recommend reading through the recipe #8515 again.
2bad497
to
a184660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Moved the skip test configuration for FCNClassifier to the estimator's _tags as for issue 8515.
EXCLUDED_TESTS
in_config.py
tests:skip_by_name
tag inFCNClassifier
classTowards #8515
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktime
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
maintainers
tag - do this if you want to become the owner or maintainer of an estimator you added.See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.