[ENH] Second Set of Test Parameters TimeSeriesForest #8337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
reviewed
Jun 3, 2025
fkiraly
requested changes
Jun 3, 2025
|
Great; thank you! |
|
actually a code formatting issue - here is how you set up automatic formatting in your dev environment: Also, you can see what exactly is wrong if you click on the failing CI job. |
|
Ouch! Thank you for highlighting the issue; I fixed the trailing whitespace in the most recent commit, fingers crossed! |
fkiraly
approved these changes
Jun 10, 2025
|
Sorry to bother, but is there any documentation available on how to proceed from here? Thank you!! |
|
the failures are unrelated, all is fine! |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Second Test Parameter Set both for
TimeSeriesForestRegressorandTimeSeriesForestClassifier, c.f. issue #3429