-
-
Notifications
You must be signed in to change notification settings - Fork 120
Open
Description
While attempting to review and leverage the TypeRefHash
, we came across a few issues we would like to bring up and hopefully resolve through discussion/implementation:
- Could you explicitly state the sort order in the definition of
TypeRefHash
? It seems the sort order is the default C# sort order, which may cause some problems as stated in subsequent bullets: - Since the C# default sort order is leveraged, the generated
TypeRefHash
may change based upon locality/language. For example, if the default language setting for a user is French, the generatedTypeRefHash
may be different than if the default language setting is English. - The C# default sort order treats some characters differently than, say, Python. Having a sorter which is language agnostic will better enable portability and implementation in other languages/environments.
- The sort order is case-insensitive, while the hash is case-sensitive. The
TypeRefHash
can be defeated by altering the case of some of the strings. In comparison, anImportHash
converts all names to lower-case before both comparing and hashing.
Metadata
Metadata
Assignees
Labels
No labels