Add Positional Getters #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for the positional getters. Added a test for non-valued boolean flags.
|
Fantastic contribution, Yetman! Thank you so much for the fix and feature addition :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since only options can be retrieved by the template
get<T>functions, positional arguments needs to be manually parsed which added unneeded verbosity to the code.This pull request adds the following functions:
std::optional<T> args::get<T>(size_t positional_index)T args::get<T>(size_t positional_index, , T&& default_value)If the
positional_indexdoesn't exist anstd::nulloptor the default value is returned.Also this pull request contains a fix for #8 and adds test cases for the aforementioned functions and fix.