-
Notifications
You must be signed in to change notification settings - Fork 11
"InitializeArguments " de-serliasation error #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eranif
commented
Jan 21, 2023
- de-serialise adapter_id from "adapterID"
- de-serialise client_id from "clientID"
de-serialise adapter_id from "adapterID"
See the spec here: request_seq fix: |
… not to camelCase
… of the arguments
changed server.run() logic to use both methods for reading the data (read_line() & read_n_bytes())
Hello, thank you for your PR! I'm a little swamped right now, but I will get back to you this weekend! |
I appreciate the initiatives, but please break this up into separate PRs, there are lots of different proposals here. To name a few:
Also, please use the rustfmt.toml config that is in the repo and try to follow the established commit message format (module: foo bar) where appropriate. |
Yes, sure, I was not aware that the PR is updated for each commit I am doing on my branch ... |