-
Notifications
You must be signed in to change notification settings - Fork 11
Remove Client and Adapter to create a simpler API #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TBH present me also prefers the more succinct example. The previous README over-explained unnecessary things (i.e. this is not the right place to learn how DAP works, there's an official documentation for that). This whole project was a distraction for me at the time and I focused on the smallest, most unimportant things possible (porting all the request and response types was a largely manual process!) I think the sensible approach is to start with minimal docs and gradually extend them as friction is encountered. |
I'll wait for your other PR to land and this one to be rebased, but on first look it looks really good - I'm humbled and thankful. Please consider adding a CONTRIBUTORS.txt and list your PRs with your name/username/email (whichever you prefer), similar to protobuf's CONTRIBUTORS.txt. Also, I'd be happy to add you as a maintainer to this repo (no commitment, just making it easier for you if you wish contribute more in the future). You can reach me on discord as |
Glad you like it 💯 Also, I'm impressed that your distractions look like this! If I ever use coding as a distraction, it usually looks a lot more sloppy! |
f69ecce
to
e45f0d6
Compare
e45f0d6
to
b061893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small nits and this is ready to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much 🎉
Note: this builds on #5 and #8, and will be rebased once those have been merged.
This removes the adapter and client, and merges the functionality of the client into the server.
You might want to check that my error handling is OK. That is one of the places where i still struggle in rust.
I got a little lazy with the examples and readme, sorry. I personally prefer a simple example instead of a long explanation, but i recognize the effort you put in and it pains me to remove it.
Feel free to add to the readme, if not, i will try to find the energy to do it.
Do say so, if you want me to split this up further or have any other feedback that could help me improve this PR 🏄🏽♀️