+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_syntax): Allow module syntax in cts files #3958

Closed
wants to merge 2 commits into from
Closed

fix(rome_js_syntax): Allow module syntax in cts files #3958

wants to merge 2 commits into from

Conversation

MichaReiser
Copy link
Contributor

Summary

Fixes #3918

Test Plan

cargo run --bin rome -- check ../rome-test/x.cts

Doesn't fail where x.cts contains

import X from "test";

@MichaReiser
fix(rome_js_syntax): Allow module syntax in cts files
7e35fee 
## Summary

Fixes #3918

## Test Plan

```bash
cargo run --bin rome -- check ../rome-test/x.cts
```

Doesn't fail where `x.cts` contains

```ts
import X from "test";
```
@MichaReiser MichaReiser added L-JavaScript Langauge: JavaScript A-Parser Area: parser labels Dec 5, 2022
@MichaReiser MichaReiser added this to the 11.0.0 milestone Dec 5, 2022
@MichaReiser MichaReiser requested a review from a team as a code owner December 5, 2022 16:41
@netlify
Copy link

netlify bot commented Dec 5, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit e992d4a
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/638e207b3a39e300087a32a8
😎 Deploy Preview https://deploy-preview-3958--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44936 44936 0
Failed 943 943 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1707 1707 0
Failed 4239 4239 0
Panics 0 0 0
Coverage 28.71% 28.71% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12397 12388 ❌ ⏬ -9
Failed 3860 3869 ❌ ⏫ +9
Panics 0 0 0
Coverage 76.26% 76.20% -0.06%
🔥 Regression (14): 
conformance/externalModules/moduleResolutionWithoutExtension6.ts
conformance/node/nodeModules1.ts
conformance/node/nodeModulesConditionalPackageExports.ts
conformance/node/nodeModulesDeclarationEmitWithPackageExports.ts
conformance/node/nodeModulesForbidenSyntax.ts
conformance/node/nodeModulesImportAssertions.ts
conformance/node/nodeModulesImportResolutionNoCycle.ts
conformance/node/nodeModulesPackageExports.ts
conformance/node/nodeModulesPackageImports.ts
conformance/node/nodeModulesPackagePatternExports.ts
conformance/node/nodeModulesPackagePatternExportsTrailers.ts
conformance/node/nodeModulesResolveJsonModule.ts
conformance/node/nodePackageSelfName.ts
conformance/node/nodePackageSelfNameScoped.ts
🎉 Fixed (5): 
compiler/nodeNextCjsNamespaceImportDefault1.ts
compiler/nodeNextCjsNamespaceImportDefault2.ts
conformance/node/nodeModulesDeclarationEmitDynamicImportWithPackageExports.ts
conformance/node/nodeModulesImportResolutionIntoExport.ts
conformance/node/nodeModulesTypesVersionPackageExports.ts

@ematipico
Copy link
Contributor

Are the regressions expected?

@MichaReiser MichaReiser modified the milestones: 11.0.0, Next Dec 6, 2022
@MichaReiser
Copy link
Contributor Author

Are the regressions expected?

I have to check and will update my test plan accordingly

@nissy-dev nissy-dev mentioned this pull request Mar 21, 2023
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Parser Area: parser L-JavaScript Langauge: JavaScript
Projects
Rome 2022
Status: Done
Milestone
v12.0.0
Development

Successfully merging this pull request may close these issues.

🐛 Illegal use of an export declaration outside of a module for .cts files
2 participants
@MichaReiser @ematipico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载