This repository was archived by the owner on Aug 31, 2023. It is now read-only.
test(rome_formatter_test): JSON Prettier Tests #2568 #3913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
denbezrukov
commented
Dec 1, 2022
..._formatter/tests/specs/prettier/typescript/angular-component-examples/test.component.ts.snap
Show resolved
Hide resolved
denbezrukov
commented
Dec 1, 2022
MichaReiser
reviewed
Dec 1, 2022
..._formatter/tests/specs/prettier/typescript/angular-component-examples/test.component.ts.snap
Show resolved
Hide resolved
crates/rome_json_formatter/tests/specs/prettier/prepare_tests.js
Outdated
Show resolved
Hide resolved
|
@leops is a test crate idiomatic Rust to share test code? |
Well using a crate is pretty much the only way to efficiently share code, plus we already have the |
7e20c36 to
0dcd37b
Compare
0dcd37b to
7453528
Compare
MichaReiser
reviewed
Dec 2, 2022
MichaReiser
reviewed
Dec 2, 2022
| } | ||
| } | ||
|
|
||
| fn is_ignored(file_name: &str) -> bool { |
There was a problem hiding this comment.
Nit: It would be nice if the ignored are handled per language. But let's leave this for another PR
MichaReiser
approved these changes
Dec 2, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial PR which implements testing for
rome_json_formatter:check_reformatlogic.prettier_testslogic.TODO:
spec_testlogic.prepare_testlogic.Open questions:
Do we need to merge prettier compatibility reports from js and json crates?
Test Plan
cargo test -p rome_js_formatter && cargo test -p rome_json_formatter