This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noUselessSwitchCase
#3912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
reviewed
Dec 1, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_useless_switch_case.rs
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Dec 1, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_useless_switch_case.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_switch_case.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Dec 7, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_useless_switch_case.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_switch_case.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_switch_case.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_switch_case.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_switch_case.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements Unicorn's no-useless-switch-case with the difference that we also handle cases after
default. This makes the Rome's rule more complete than Unicorn's one.Impl choices
I chose to remove comments just before and after a useless case:
switch (foo) { - /* remove comment */ case 0: /* remove comment */ // keep comment default: break; }And to transfer the comment just before the statement list:
switch (foo) { - default: /* keep comment */ - /* remove comment */ case 0: /* transfer this comment */ + default: /* keep comment *//* transfer this comment */ break; }Test Plan
Unit test and doc-tests included.