This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(playground): Script Type #3903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the Source Type `Script` option on the playground. The issue is that Rome only parses `cjs` and `cts` files as scripts and all other extensions as modules. This PR updates the playground's extension mapping to correctly use `cjs` and `cts` for scripts
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
approved these changes
Nov 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Source Type
Scriptoption on the playground.The issue is that Rome only parses
cjsandctsfiles as scripts and all other extensions as modules. This PR updates the playground's extension mapping to correctly usecjsandctsfor scripts