rome · leops · Dec 5, 2022 · Nov 30, 2022 · Dec 2, 2022 · Dec 5, 2022
diff --git a/benchmark/bench.rome.json b/benchmark/bench.rome.json
@@ -14,7 +14,7 @@
                 "noDebugger": "error",
                 "noDelete": "error",
                 "noDoubleEquals": "error",
-                "noDupeArgs": "error",
+                "noDuplicateParameters": "error",
                 "noEmptyPattern": "error",
                 "noFunctionAssign": "error",
                 "noImportAssign": "error",

diff --git a/crates/rome_analyze/src/lib.rs b/crates/rome_analyze/src/lib.rs
@@ -626,19 +626,19 @@ fn range_match(filter: Option<TextRange>, range: TextRange) -> bool {
 ///
 /// - `// rome-ignore format` -> `vec![]`
 /// - `// rome-ignore lint` -> `vec![Everything]`
-/// - `// rome-ignore lint/correctness/useWhile` -> `vec![Rule("correctness/useWhile")]`
-/// - `// rome-ignore lint/correctness/useWhile lint/nursery/noUnreachable` -> `vec![Rule("correctness/useWhile"), Rule("nursery/noUnreachable")]`
-/// - `// rome-ignore lint(correctness/useWhile)` -> `vec![MaybeLegacy("correctness/useWhile")]`
-/// - `// rome-ignore lint(correctness/useWhile) lint(nursery/noUnreachable)` -> `vec![MaybeLegacy("correctness/useWhile"), MaybeLegacy("nursery/noUnreachable")]`
+/// - `// rome-ignore lint/style/useWhile` -> `vec![Rule("style/useWhile")]`
+/// - `// rome-ignore lint/style/useWhile lint/nursery/noUnreachable` -> `vec![Rule("style/useWhile"), Rule("nursery/noUnreachable")]`
+/// - `// rome-ignore lint(style/useWhile)` -> `vec![MaybeLegacy("style/useWhile")]`
+/// - `// rome-ignore lint(style/useWhile) lint(nursery/noUnreachable)` -> `vec![MaybeLegacy("style/useWhile"), MaybeLegacy("nursery/noUnreachable")]`
 type SuppressionParser<D> = fn(&str) -> Vec<Result<SuppressionKind, D>>;
 
 /// This enum is used to categorize what is disabled by a suppression comment and with what syntax
 pub enum SuppressionKind<'a> {
     /// A suppression disabling all lints eg. `// rome-ignore lint`
     Everything,
-    /// A suppression disabling a specific rule eg. `// rome-ignore lint/correctness/useWhile`
+    /// A suppression disabling a specific rule eg. `// rome-ignore lint/style/useWhile`
     Rule(&'a str),
-    /// A suppression using the legacy syntax to disable a specific rule eg. `// rome-ignore lint(correctness/useWhile)`
+    /// A suppression using the legacy syntax to disable a specific rule eg. `// rome-ignore lint(style/useWhile)`
     MaybeLegacy(&'a str),
 }
 

diff --git a/crates/rome_cli/tests/commands/check.rs b/crates/rome_cli/tests/commands/check.rs
@@ -33,6 +33,7 @@ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
 "#;
 
 const NO_DEBUGGER: &str = "debugger;";
+const NEW_SYMBOL: &str = "new Symbol(\"\");";
 
 const FIX_BEFORE: &str = "
 if(a != -0) {}
@@ -68,8 +69,7 @@ const UPGRADE_SEVERITY_CODE: &str = r#"class A extends B {
     constructor() {}
 }"#;
 
-const NURSERY_UNSTABLE: &str = r#"const array = ["split", "the text", "into words"];
-array.map(sentence => sentence.split(' ')).flat();"#;
+const NURSERY_UNSTABLE: &str = r#"if(a = b) {}"#;
 
 #[test]
 fn ok() {
@@ -174,6 +174,8 @@ fn maximum_diagnostics() {
         Arguments::from_vec(vec![OsString::from("check"), file_path.as_os_str().into()]),
     );
 
+    println!("{console:#?}");
+
     assert!(result.is_err(), "run_cli returned {result:?}");
 
     let messages = &console.out_buffer;
@@ -193,7 +195,7 @@ fn maximum_diagnostics() {
             let content = format!("{:?}", m.content);
             content.contains("The number of diagnostics exceeds the number allowed by Rome")
                 && content.contains("Diagnostics not shown")
-                && content.contains("76")
+                && content.contains("28")
         }));
 
     assert_cli_snapshot(SnapshotPayload::new(
@@ -539,7 +541,7 @@ fn downgrade_severity() {
             .filter(|m| m.level == LogLevel::Error)
             .filter(|m| {
                 let content = format!("{:#?}", m.content);
-                content.contains("correctness/noDebugger")
+                content.contains("suspicious/noDebugger")
             })
             .count(),
         1
@@ -993,7 +995,7 @@ fn max_diagnostics_default() {
     let mut console = BufferConsole::default();
 
     // Creates 40 diagnostics.
-    for i in 0..20 {
+    for i in 0..40 {
         let file_path = PathBuf::from(format!("src/file_{i}.js"));
         fs.insert(file_path, LINT_ERROR.as_bytes());
     }
@@ -1043,7 +1045,7 @@ fn max_diagnostics() {
     let mut fs = MemoryFileSystem::default();
     let mut console = BufferConsole::default();
 
-    for i in 0..10 {
+    for i in 0..20 {
         let file_path = PathBuf::from(format!("src/file_{i}.js"));
         fs.insert(file_path, LINT_ERROR.as_bytes());
     }
@@ -1123,7 +1125,7 @@ fn deprecated_suppression_comment() {
     let file_path = Path::new("file.js");
     fs.insert(
         file_path.into(),
-        *b"// rome-ignore lint(correctness/noDoubleEquals): test
+        *b"// rome-ignore lint(suspicious/noDoubleEquals): test
 a == b;",
     );
 
@@ -1244,7 +1246,7 @@ fn config_recommended_group() {
     fs.insert(file_path.into(), CONFIG_RECOMMENDED_GROUP.as_bytes());
 
     let file_path = Path::new("check.js");
-    fs.insert(file_path.into(), NO_DEBUGGER.as_bytes());
+    fs.insert(file_path.into(), NEW_SYMBOL.as_bytes());
 
     let result = run_cli(
         DynRef::Borrowed(&mut fs),

diff --git a/crates/rome_cli/tests/configs.rs b/crates/rome_cli/tests/configs.rs
@@ -54,11 +54,13 @@ pub const CONFIG_ALL_FIELDS: &str = r#"{
             }
         },
         "correctness": {
+            "noUnreachable": "off"
+        },
+        "suspicious": {
             "noCatchAssign": "error",
             "noLabelVar": {
                 "level": "warn"
-            },
-            "noUnreachable": "off"
+            }
         }
     }
   },
@@ -110,7 +112,7 @@ pub const CONFIG_LINTER_SUPPRESSED_RULE: &str = r#"{
   "linter": {
     "rules": {
         "recommended": true,
-        "correctness": {
+        "suspicious": {
             "noDebugger": "off"
         }
     }
@@ -132,7 +134,7 @@ pub const CONFIG_LINTER_DOWNGRADE_DIAGNOSTIC: &str = r#"{
   "linter": {
     "rules": {
         "recommended": true,
-        "correctness": {
+        "suspicious": {
             "noDebugger": "warn"
         }
     }

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/config_recommended_group.snap b/crates/rome_cli/tests/snapshots/main_commands_check/config_recommended_group.snap
@@ -20,7 +20,7 @@ expression: content
 ## `check.js`
 
 ```js
-debugger;
+new Symbol("");
 ```
 
 # Termination Message
@@ -32,17 +32,17 @@ some errors were emitted while running checks
 # Emitted Messages
 
 ```block
-check.js:1:1 lint/correctness/noDebugger  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+check.js:1:1 lint/correctness/noNewSymbol  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × This is an unexpected use of the debugger statement.
+  × Symbol cannot be called as a constructor.
 
-  > 1 │ debugger;
-      │ ^^^^^^^^^
+  > 1 │ new Symbol("");
+      │ ^^^^^^^^^^^^^^
 
-  i Suggested fix: Remove debugger statement
+  i Suggested fix: Remove new.
 
-    1 │ debugger;
-      │ ---------
+    1 │ new·Symbol("");
+      │ ----           
 
 ```
 

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/deprecated_suppression_comment.snap b/crates/rome_cli/tests/snapshots/main_commands_check/deprecated_suppression_comment.snap
@@ -5,7 +5,7 @@ expression: content
 ## `file.js`
 
 ```js
-// rome-ignore lint(correctness/noDoubleEquals): test
+// rome-ignore lint(suspicious/noDoubleEquals): test
 a == b;
 ```
 
@@ -16,14 +16,14 @@ file.js:1:1 suppressions/deprecatedSyntax  FIXABLE  ━━━━━━━━━
 
   ! Suppression is using a deprecated syntax
 
-  > 1 │ // rome-ignore lint(correctness/noDoubleEquals): test
-      │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  > 1 │ // rome-ignore lint(suspicious/noDoubleEquals): test
+      │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     2 │ a == b;
 
   i Safe fix: Rewrite suppression to use the newer syntax
 
-    1   │ - //·rome-ignore·lint(correctness/noDoubleEquals):·test
-      1 │ + //·rome-ignore·lint/correctness/noDoubleEquals:·test
+    1   │ - //·rome-ignore·lint(suspicious/noDoubleEquals):·test
+      1 │ + //·rome-ignore·lint/suspicious/noDoubleEquals:·test
     2 2 │   a == b;
 
 

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/downgrade_severity.snap b/crates/rome_cli/tests/snapshots/main_commands_check/downgrade_severity.snap
@@ -9,7 +9,7 @@ expression: content
   "linter": {
     "rules": {
         "recommended": true,
-        "correctness": {
+        "suspicious": {
             "noDebugger": "warn"
         }
     }
@@ -26,7 +26,7 @@ debugger;
 # Emitted Messages
 
 ```block
-file.js:1:1 lint/correctness/noDebugger  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+file.js:1:1 lint/suspicious/noDebugger  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! This is an unexpected use of the debugger statement.
 

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/lint_error.snap b/crates/rome_cli/tests/snapshots/main_commands_check/lint_error.snap
@@ -18,7 +18,7 @@ some errors were emitted while running checks
 # Emitted Messages
 
 ```block
-check.js:1:1 lint/correctness/useWhile  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+check.js:1:1 lint/style/useWhile  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   × Use while loops instead of for loops.
 
@@ -33,24 +33,6 @@ check.js:1:1 lint/correctness/useWhile  FIXABLE  ━━━━━━━━━━
     2 2 │   
 
 
-```
-
-```block
-check.js:1:1 lint/style/useBlockStatements  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  × Block statements are preferred in this position.
-
-  > 1 │ for(;true;);
-      │ ^^^^^^^^^^^^
-    2 │ 
-
-  i Suggested fix: Wrap the statement with a `JsBlockStatement`
-
-    1   │ - for(;true;);
-      1 │ + for(;true;)·{}
-    2 2 │   
-
-
 ```
 
 ```block

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/max_diagnostics.snap b/crates/rome_cli/tests/snapshots/main_commands_check/max_diagnostics.snap
@@ -16,6 +16,76 @@ for(;true;);
 
 ```
 
+## `src/file_10.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_11.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_12.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_13.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_14.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_15.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_16.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_17.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_18.js`
+
+```js
+for(;true;);
+
+```
+
+## `src/file_19.js`
+
+```js
+for(;true;);
+
+```
+
 ## `src/file_2.js`
 
 ```js
@@ -86,7 +156,7 @@ Diagnostics not shown: 10.
 ```
 
 ```block
-Checked 10 file(s) in <TIME>
+Checked 20 file(s) in <TIME>
 ```