This repository was archived by the owner on Aug 31, 2023. It is now read-only.
release: 11.0.0 #3906
Merged
release: 11.0.0 #3906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
523db10 to
cf64e21
Compare
qweered
reviewed
Dec 4, 2022
leops
reviewed
Dec 5, 2022
Co-authored-by: l3ops <leops@users.noreply.github.com>
MichaReiser
approved these changes
Dec 5, 2022
Co-authored-by: Micha Reiser <micha@rome.tools>
Co-authored-by: Micha Reiser <micha@rome.tools>
Co-authored-by: Micha Reiser <micha@rome.tools>
leops
reviewed
Dec 5, 2022
MichaReiser
reviewed
Dec 5, 2022
MichaReiser
reviewed
Dec 5, 2022
Co-authored-by: Micha Reiser <micha@rome.tools> Co-authored-by: l3ops <leops@users.noreply.github.com>
egilsster
reviewed
Dec 5, 2022
MichaReiser
reviewed
Dec 6, 2022
website/src/pages/configuration.mdx
Outdated
|
|
||
| It configures where the formatter prints semicolons: | ||
| - `always`, the semicolons is always added at the end of each statement; | ||
| - `as-needed`, the semicolons are added only in places where it's needed, to protect from [ASI](https://en.wikibooks.org/wiki/JavaScript/Automatic_semicolon_insertion) |
There was a problem hiding this comment.
The value is asNeeded (only the cli option is as-needed).
|
@leops can you extend the editor README with an entry for sorting imports on save? "editor.codeActionsOnSave": {
"source.organizeImports.rome": true
} |
As part of this I tried to use the |
MichaReiser
reviewed
Dec 6, 2022
Co-authored-by: Micha Reiser <micha@rome.tools>
47ae4a1 to
140ea48
Compare
leops
approved these changes
Dec 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3716
@rome/staff please add/change the sections you want
Test Plan
Rendered changelog
Website