This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): implement noNonNullAssertion rule
#3891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
notmd
commented
Nov 28, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_non_null_assertion.rs
Outdated
Show resolved
Hide resolved
MichaReiser
reviewed
Nov 29, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_non_null_assertion.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_non_null_assertion.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_non_null_assertion.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_non_null_assertion.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_non_null_assertion.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_non_null_assertion.rs
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Nov 30, 2022
ematipico
approved these changes
Nov 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement noNonNullAssertion rule.
Test Plan
All the tests are taken from the Typescript Eslint tests.