This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noRedundantUseStrict rule
#3895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
mzbac
commented
Nov 29, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
leops
reviewed
Nov 29, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
MichaReiser
reviewed
Nov 29, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
|
The PR title should certainly start with |
MichaReiser
reviewed
Nov 29, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
NoRedundantUseStrict ruleNoRedundantUseStrict rule
leops
reviewed
Nov 29, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
NoRedundantUseStrict rulenoRedundantUseStrict rule
noRedundantUseStrict rulenoRedundantUseStrict rule
MichaReiser
suggested changes
Nov 30, 2022
There was a problem hiding this comment.
There are a few simplifications that we can make and I don't think the rule handles the case where a function has two use strict directives correctly yet.
We can merge this PR after these things have been changed and add support for classes and modules, where strict mode is enabled by default, separately.
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Nov 30, 2022
ematipico
approved these changes
Nov 30, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
…strict.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
…strict.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There used to be a parse check of the "use strict" directive and an error would be thrown when encountering redundant "use strict" directives; however, it should be a linter error rather than a parser warning.
So this PR is for addressing that: -> #2678
Test Plan
Tests are added as part of the implementation.