+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_syntax,rome_json_syntax): Rename JsAny... to AnyJs... #3883

Merged
merged 4 commits into from
Nov 28, 2022
Merged

refactor(rome_js_syntax,rome_json_syntax): Rename JsAny... to AnyJs... #3883

merged 4 commits into from
Nov 28, 2022

Conversation

MichaReiser
Copy link
Contributor

Summary

This PR renames the union node types from JsAny*, TsAny*, JsxAny* to AnyJs*, AnyTs*, or AnyJsx*.

This change is because the JsAny naming can conflict with a language syntax. For example, the node for the TypeScript any type is called TsAnyType but it isn't a union. Naming our unions AnyTsType avoids this naming clash.

This PR renames the TsType union to AnyTsType

Test Plan

cargo test

@MichaReiser MichaReiser added L-JavaScript Langauge: JavaScript L-JSON Language: JSON I-Easy Implementation: easy task, usually a good fit for new contributors labels Nov 28, 2022
@MichaReiser MichaReiser marked this pull request as ready for review November 28, 2022 11:36
@MichaReiser MichaReiser requested review from leops, ematipico, xunilrj and a team as code owners November 28, 2022 11:36
@leops leops mentioned this pull request Nov 28, 2022
Merged
Base automatically changed from refactor/bogus to main November 28, 2022 15:26
@netlify
Copy link

netlify bot commented Nov 28, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 3913c79
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6384d71e8343ed0008d53d04

@calibre-analytics
Copy link

calibre-analytics bot commented Nov 28, 2022 •
edited
Loading

Comparing refactor(rome_js_syntax,rome_json_syntax): Rename JsAny... to AnyJs... Snapshot #2 to median since last deploy of rome.tools.

LCP? CLS? TBT?
Overall
Median across all pages and test profiles		 2.81s 
from 281ms		 0.0
no change		 195ms
no change
Chrome Desktop
Chrome Desktop • Cable		 2.81s 
from 281ms		 0.0
no change		 377ms 
from 4ms
iPhone, 4G LTE
iPhone 12 • 4G LTE		 1.11s 
from 242ms		 0.0
no change		 8ms
no change
Motorola Moto G Power, 3G connection
Motorola Moto G Power • Regular 3G		 16.5s 
from 1.06s		 0.0
no change		 195ms
no change

1 page tested

 Home

Browser previews

Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection
Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection

Most significant changes

Value Budget
Total Blocking Time
Chrome Desktop		 377ms 
from 4ms
JS Parse & Compile
Motorola Moto G Power, 3G connection		 1.77s 
from 25ms
Total JavaScript Size in Bytes
Chrome Desktop		 5.37 MB 
from 86.8 KB
Total JavaScript Size in Bytes
iPhone, 4G LTE		 5.36 MB 
from 86.8 KB
Total JavaScript Size in Bytes
Motorola Moto G Power, 3G connection		 5.36 MB 
from 86.8 KB

27 other significant changes: JS Parse & Compile on iPhone, 4G LTE, JS Parse & Compile on Chrome Desktop, First Contentful Paint on Motorola Moto G Power, 3G connection, Largest Contentful Paint on Motorola Moto G Power, 3G connection, Total CSS Size in Bytes on Chrome Desktop, Total CSS Size in Bytes on iPhone, 4G LTE, Total CSS Size in Bytes on Motorola Moto G Power, 3G connection, Time to Interactive on Motorola Moto G Power, 3G connection, Time to Interactive on Chrome Desktop, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Largest Contentful Paint on Chrome Desktop, First Contentful Paint on Chrome Desktop, Number of Requests on Motorola Moto G Power, 3G connection, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Speed Index on Motorola Moto G Power, 3G connection, Time to Interactive on iPhone, 4G LTE, First Contentful Paint on iPhone, 4G LTE, Largest Contentful Paint on iPhone, 4G LTE, Speed Index on Chrome Desktop, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings | View documentation

@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44936 44936 0
Failed 943 943 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1757 1757 0
Failed 4189 4189 0
Panics 0 0 0
Coverage 29.55% 29.55% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12397 12397 0
Failed 3860 3860 0
Panics 0 0 0
Coverage 76.26% 76.26% 0.00%

@MichaReiser MichaReiser merged commit 2655264 into main Nov 28, 2022
@MichaReiser MichaReiser deleted the refactor/any-nodes branch November 28, 2022 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops approved these changes

@ematipico ematipico Awaiting requested review from ematipico

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees
No one assigned
Labels
I-Easy Implementation: easy task, usually a good fit for new contributors L-JavaScript Langauge: JavaScript L-JSON Language: JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @leops
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载