This repository was archived by the owner on Aug 31, 2023. It is now read-only.
chore(ci): resolve main branch ci error #3870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
|
Thank you. I addressed the issue in #3869 by normalizing the snapshots. This has the advantage that it works cross platform (for users with non standard temp directories or platforms with different temp paths) |
|
OK 👍 I close this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I try to fix CI error in main branch. The reason why the tests failed in main branch is that snapshots result is different between Ubuntu and MacOS. So, I created each snapshot results.
Test Plan
I confirmed all workflows passed in my forked repo. see nissy-dev#4