+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore: Remove unused dependencies #3879

Merged
merged 3 commits into from
Nov 28, 2022
Merged

chore: Remove unused dependencies #3879

merged 3 commits into from
Nov 28, 2022

Conversation

MichaReiser
Copy link
Contributor

^^

@netlify
Copy link

netlify bot commented Nov 28, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit de2e7dc
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63849f01212ec80008a87c9c

@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44936 44936 0
Failed 943 943 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1757 1757 0
Failed 4189 4189 0
Panics 0 0 0
Coverage 29.55% 29.55% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12397 12397 0
Failed 3860 3860 0
Panics 0 0 0
Coverage 76.26% 76.26% 0.00%

@MichaReiser MichaReiser marked this pull request as ready for review November 28, 2022 11:54
@MichaReiser MichaReiser requested review from ematipico, leops, xunilrj and a team as code owners November 28, 2022 11:54
leops
leops approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@leops leops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could run something like cargo udeps somewhere in our CI to try to catch these in an automated way

@MichaReiser MichaReiser merged commit a0d9a08 into main Nov 28, 2022
@MichaReiser MichaReiser deleted the chore/remove-unused-dependencies branch November 28, 2022 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops approved these changes

@ematipico ematipico Awaiting requested review from ematipico

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @leops
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载