+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_syntax): Rename Template, NewTarget, and ImportMeta #3878

Merged
merged 1 commit into from
Nov 28, 2022
Merged

refactor(rome_js_syntax): Rename Template, NewTarget, and ImportMeta #3878

merged 1 commit into from
Nov 28, 2022

Conversation

MichaReiser
Copy link
Contributor

... to

  • JsTemplateExpression
  • JsNewTargetExpression
  • JsImportMetaExpression

so that the names follow our naming convention

@MichaReiser MichaReiser added the L-JavaScript Langauge: JavaScript label Nov 28, 2022
@MichaReiser MichaReiser requested review from leops, xunilrj, ematipico and a team as code owners November 28, 2022 09:05
@netlify
Copy link

netlify bot commented Nov 28, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 8c2f4f4
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63847b6e80f4fe00085aec96

@MichaReiser MichaReiser added the I-Easy Implementation: easy task, usually a good fit for new contributors label Nov 28, 2022
@MichaReiser
refactor(rome_js_syntax): Rename Template, NewTarget, and `Import…
8c2f4f4 
…Meta`

... to

* `JsTemplateExpression`
* `JsNewTargetExpression`
* `JsImportMetaExpression`

so that the names follow our naming convention
@MichaReiser MichaReiser force-pushed the refactor/js-expressions branch from 8d65b0f to 8c2f4f4 Compare November 28, 2022 09:12
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44936 44936 0
Failed 943 943 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1757 1757 0
Failed 4189 4189 0
Panics 0 0 0
Coverage 29.55% 29.55% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12397 12397 0
Failed 3860 3860 0
Panics 0 0 0
Coverage 76.26% 76.26% 0.00%

leops
leops approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@leops leops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember having to introduce a few special case for these nodes in the classification logic of name_to_module in xtask/codegen/src/formatter.rs that are probably no longer necessary now that they follow the general naming convention

@MichaReiser
Copy link
Contributor Author

I remember having to introduce a few special case for these nodes in the classification logic of name_to_module in xtask/codegen/src/formatter.rs that are probably no longer necessary now that they follow the general naming convention

I removed the special cases in one of the follow up prs

@MichaReiser MichaReiser merged commit fcdff03 into main Nov 28, 2022
@MichaReiser MichaReiser deleted the refactor/js-expressions branch November 28, 2022 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops approved these changes

@xunilrj xunilrj Awaiting requested review from xunilrj

@ematipico ematipico Awaiting requested review from ematipico

Assignees
No one assigned
Labels
I-Easy Implementation: easy task, usually a good fit for new contributors L-JavaScript Langauge: JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @leops
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载