+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_json_syntax): Introduce JsonMemberName #3876

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

MichaReiser
Copy link
Contributor

Summary

This PR introduces a new JsonMemberName to distinguish between string literals in value or member name positions, similar to how it's done for JavaScript. A different node type simplifies querying for member names.

This PR further postfixes all values with Value as it is done with Expressions

@MichaReiser MichaReiser added L-JSON Language: JSON I-Easy Implementation: easy task, usually a good fit for new contributors labels Nov 28, 2022
@MichaReiser MichaReiser requested review from ematipico and a team as code owners November 28, 2022 07:38
@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 77c2758
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63847b7b4309110009347612

This PR introduces a new `JsonMemberName` to distinguish between string literals in value or member name positions, similar to how it's done for JavaScript. A different node type simplifies querying for member names.

This PR further postfixes all values with `Value` as it is done with `Expression`s
@MichaReiser MichaReiser merged commit b9efd41 into main Nov 28, 2022
@MichaReiser MichaReiser deleted the refactor/json-value branch November 28, 2022 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I-Easy Implementation: easy task, usually a good fit for new contributors L-JSON Language: JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载