This repository was archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_json_syntax): Introduce JsonMemberName
#3876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new
JsonMemberName
to distinguish between string literals in value or member name positions, similar to how it's done for JavaScript. A different node type simplifies querying for member names.This PR further postfixes all values with
Value
as it is done withExpression
s