This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): fix noShoutyConstants with empty string #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
MichaReiser
suggested changes
Nov 26, 2022
crates/rome_js_analyze/src/semantic_analyzers/style/no_shouty_constants.rs
Show resolved
Hide resolved
MichaReiser
approved these changes
Nov 26, 2022
|
|
||
| for (from_id, from_literal) in id_text.chars().zip(literal_text.chars()) { | ||
| if from_id != from_literal { | ||
| return None; |
There was a problem hiding this comment.
Nit: We can remove one of the is_lowercase checks below. Either they are both lowercase or both are not.
MichaReiser
approved these changes
Nov 26, 2022
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3867
Test Plan
With some new test cases which were missing: