This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_diagnostics): add with_severity API
#3823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
d2567a4 to
2a2e39e
Compare
leops
reviewed
Nov 22, 2022
| @@ -42,6 +42,11 @@ pub trait DiagnosticExt: internal::Sealed + Sized { | |||
| fn with_tags(self, tags: DiagnosticTags) -> Error | |||
| where | |||
| Error: From<internal::TagsDiagnostic<Self>>; | |||
|
|
|||
| /// Returns a new diagnostic with additional `severity` | |||
| fn with_severity(self, severity: Severity) -> Error | |||
There was a problem hiding this comment.
For feature parity, can we add this new method to the Context trait too ? (It looks like I forgot to add a few methods from DiagnosticExt in that trait already already, but in theory they should be kept in sync)
There was a problem hiding this comment.
I also added with_tags
bb51ac8 to
0adaebe
Compare
leops
approved these changes
Nov 25, 2022
0adaebe to
64c2be7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new API to
DiagnosticExtcalledwith_severity, which allows changing the severity of a diagnostic in a "native" way.This change allows removing an API I had to create in the
AnalyzerDiagnostic, which is not needed anymore.Test Plan
This is a "under the hoods" change, which means that the existing tests should pass.