+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

docs(website): add language support page #3751

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Nov 15, 2022

Summary

Closes #3631

I added the version of TS that we support. Let me know if it's wrong.

Test Plan

Rendered website

@ematipico ematipico requested a review from a team November 15, 2022 17:44
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 5672096
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6376783c3dcff90008c16211
😎 Deploy Preview https://deploy-preview-3751--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind running the changes through a grammar checker like grammarly.com

@ematipico ematipico force-pushed the website/langauge-support branch from 8162045 to 8380882 Compare November 16, 2022 10:46
Comment on lines 23 to 26
Rome supports only the official syntax. The team starts development of the new syntax when a proposal reaches
[Stage 3](https://github.com/tc39/proposals#stage-3).

Rome supports the ES2022 version of the language.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we flip the order of the sentence (same for typescript)? Stating the version is the most important information and the second sentence is a more in-depth explanation.

@ematipico ematipico force-pushed the website/langauge-support branch from 8380882 to 5672096 Compare November 17, 2022 18:06
@ematipico ematipico merged commit 2464868 into main Nov 17, 2022
@ematipico ematipico deleted the website/langauge-support branch November 17, 2022 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Add back language matrix to docs
2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载