+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noPrecisionLoss #3756

Merged
merged 13 commits into from
Nov 18, 2022
Merged

feat(rome_js_analyze): noPrecisionLoss #3756

merged 13 commits into from
Nov 18, 2022

Conversation

95th
Copy link
Contributor

@95th 95th commented Nov 16, 2022 •
edited
Loading

Summary

Implement eslint's no-loss-of-precision lint.

Test Plan

Added unit tests.

@95th 95th requested a review from a team November 16, 2022 02:19
@netlify
Copy link

netlify bot commented Nov 16, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7a2d33a
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637680c50268750008ed3112
😎 Deploy Preview https://deploy-preview-3756--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

MichaReiser
MichaReiser reviewed Nov 16, 2022
View reviewed changes
@MichaReiser
Copy link
Contributor

!bench_analyzer

@github-actions
Copy link

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      2.6±0.09ms     4.4 MB/sec    1.04      2.7±0.15ms     4.2 MB/sec
analyzer/index.js         1.00      7.5±0.32ms     4.4 MB/sec    1.03      7.7±0.29ms     4.3 MB/sec
analyzer/lint.ts          1.00      3.6±0.10ms    11.5 MB/sec    1.03      3.7±0.09ms    11.2 MB/sec
analyzer/parser.ts        1.00      8.7±0.35ms     5.6 MB/sec    1.02      8.9±0.39ms     5.5 MB/sec
analyzer/router.ts        1.00      6.0±0.16ms    10.2 MB/sec    1.04      6.2±0.19ms     9.8 MB/sec
analyzer/statement.ts     1.00      8.4±0.27ms     4.2 MB/sec    1.05      8.9±0.33ms     4.0 MB/sec
analyzer/typescript.ts    1.00     13.0±0.49ms     4.2 MB/sec    1.01     13.2±0.53ms     4.1 MB/sec

@MichaReiser MichaReiser added the A-Linter Area: linter label Nov 16, 2022
@MichaReiser MichaReiser added this to the 11.0.0 milestone Nov 16, 2022
leops
leops approved these changes Nov 17, 2022
View reviewed changes
@MichaReiser
Copy link
Contributor

@95th there's a formatting issue that prevents me from merging the PR.

@95th
Copy link
Contributor Author

95th commented Nov 17, 2022

@MichaReiser Fixed now.

ematipico
ematipico reviewed Nov 17, 2022
View reviewed changes
@95th 95th requested review from ematipico and removed request for xunilrj November 18, 2022 02:36
@ematipico ematipico merged commit bb19ff5 into rome:main Nov 18, 2022
@95th 95th deleted the no_precision_loss branch November 18, 2022 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

@MichaReiser MichaReiser MichaReiser approved these changes

@leops leops leops approved these changes

Assignees
No one assigned
Labels
A-Linter Area: linter
Projects
Rome 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@95th @MichaReiser @ematipico @leops
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载