+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

docs(formatter): configuration using rome.json #3689

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Nov 12, 2022

No description provided.

@simon04 simon04 requested a review from a team November 12, 2022 19:22
@netlify
Copy link

netlify bot commented Nov 12, 2022

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3df43cf
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637fba48680d2f00094c255c
😎 Deploy Preview https://deploy-preview-3689--docs-rometools.netlify.app/formatter
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -49,6 +49,23 @@ OPTIONS:
--stdin-file-path <string> A file name with its extension to pass when reading from standard in, e.g. echo 'let a;' | rome format --stdin-file-path file.js
```

## Configuration

You may want to [configure rome](/configuration/#formatter) using `rome.json`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a mention that the values below are our defaults?

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon04 happy to merge once Sebastian's feedback is addressed

@simon04
Copy link
Contributor Author

simon04 commented Nov 24, 2022

Hi, thanks for looking at this PR. I've addressed the "defaults".

@ematipico ematipico merged commit b7eb6fd into rome:main Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载