+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore: Upgrade to Rust 1.65.0 #3557

Merged
merged 3 commits into from
Nov 4, 2022
Merged

chore: Upgrade to Rust 1.65.0 #3557

merged 3 commits into from
Nov 4, 2022

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Nov 3, 2022 •
edited
Loading

Summary

Updates Rome to use Rust 1.65.0

Test Plan

cargo test

@MichaReiser
Copy link
Contributor Author

!bench_analyzer

@MichaReiser
Copy link
Contributor Author

!bench_formatter

@MichaReiser
Copy link
Contributor Author

!bench_parser

@MichaReiser
Copy link
Contributor Author

@leops is https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html something we may want to use for our diagnostics?

@netlify
Copy link

netlify bot commented Nov 3, 2022 •
edited
Loading

✅ Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit 11e5d53
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/6363f2076ccafd000976b087

@MichaReiser MichaReiser temporarily deployed to netlify-playground November 3, 2022 16:08 Inactive
@MichaReiser
Copy link
Contributor Author

@leops is https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html something we may want to use for our diagnostics?

@github-actions
Copy link

github-actions bot commented Nov 3, 2022 •
edited
Loading

Playground for commit 77b4eb6

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44939 44939 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1621 1621 0
Failed 4325 4325 0
Panics 0 0 0
Coverage 27.26% 27.26% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12395 12395 0
Failed 3862 3862 0
Panics 0 0 0
Coverage 76.24% 76.24% 0.00%

@leops
Copy link
Contributor

leops commented Nov 3, 2022

@leops is https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html something we may want to use for our diagnostics?

Not at the moment since the Backtrace type in the standard library does not expose a stable API to inspect the frames of the backtrace yet (which is used to customize how backtraces are printed as markup, filter out irrelevant frames and enable the backtraces to be serialized), so we still have to rely on the backtrace crate for now

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.01      2.4±0.02ms     4.8 MB/sec    1.00      2.4±0.01ms     4.9 MB/sec
analyzer/index.js         1.01      6.7±0.03ms     4.9 MB/sec    1.00      6.6±0.01ms     4.9 MB/sec
analyzer/lint.ts          1.05      3.1±0.02ms    13.5 MB/sec    1.00      3.0±0.01ms    14.1 MB/sec
analyzer/parser.ts        1.03      7.9±0.09ms     6.2 MB/sec    1.00      7.7±0.01ms     6.3 MB/sec
analyzer/router.ts        1.03      5.8±0.03ms    10.6 MB/sec    1.00      5.6±0.02ms    10.9 MB/sec
analyzer/statement.ts     1.01      8.4±0.05ms     4.2 MB/sec    1.00      8.3±0.01ms     4.3 MB/sec
analyzer/typescript.ts    1.01     13.2±0.03ms     4.1 MB/sec    1.00     13.1±0.03ms     4.2 MB/sec

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Parser Benchmark Results

group                                 main                                   pr
-----                                 ----                                   --
parser/checker.ts                     1.02    128.4±2.60ms    20.2 MB/sec    1.00    125.4±2.93ms    20.7 MB/sec
parser/compiler.js                    1.00     72.6±2.66ms    14.4 MB/sec    1.00     72.7±2.45ms    14.4 MB/sec
parser/d3.min.js                      1.00     42.4±0.69ms     6.2 MB/sec    1.00     42.6±1.36ms     6.2 MB/sec
parser/dojo.js                        1.00      3.6±0.01ms    19.1 MB/sec    1.02      3.7±0.01ms    18.8 MB/sec
parser/ios.d.ts                       1.02    112.3±1.61ms    16.6 MB/sec    1.00    109.7±1.67ms    17.0 MB/sec
parser/jquery.min.js                  1.00     11.2±0.04ms     7.4 MB/sec    1.01     11.3±0.17ms     7.3 MB/sec
parser/math.js                        1.02     87.3±2.13ms     7.4 MB/sec    1.00     85.3±1.72ms     7.6 MB/sec
parser/parser.ts                      1.00      2.6±0.01ms    18.8 MB/sec    1.01      2.6±0.00ms    18.6 MB/sec
parser/pixi.min.js                    1.01     53.2±1.33ms     8.2 MB/sec    1.00     52.5±1.34ms     8.4 MB/sec
parser/react-dom.production.min.js    1.01     15.2±0.08ms     7.6 MB/sec    1.00     15.1±0.05ms     7.6 MB/sec
parser/react.production.min.js        1.00    778.0±1.49µs     7.9 MB/sec    1.02    790.5±1.35µs     7.8 MB/sec
parser/router.ts                      1.00      2.1±0.00ms    28.7 MB/sec    1.01      2.2±0.01ms    28.4 MB/sec
parser/tex-chtml-full.js              1.02    121.9±1.80ms     7.5 MB/sec    1.00    119.9±1.91ms     7.6 MB/sec
parser/three.min.js                   1.02     59.9±1.29ms     9.8 MB/sec    1.00     58.6±1.28ms    10.0 MB/sec
parser/typescript.js                  1.05    536.1±8.07ms    17.7 MB/sec    1.00    510.1±7.81ms    18.6 MB/sec
parser/vue.global.prod.js             1.01     18.5±0.15ms     6.5 MB/sec    1.00     18.4±0.08ms     6.5 MB/sec

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Formatter Benchmark Results

group                                    main                                   pr
-----                                    ----                                   --
formatter/checker.ts                     1.00    399.8±3.00ms     6.5 MB/sec    1.04    415.4±2.95ms     6.3 MB/sec
formatter/compiler.js                    1.00    221.0±1.20ms     4.7 MB/sec    1.02    225.7±0.96ms     4.6 MB/sec
formatter/d3.min.js                      1.00    173.2±0.85ms  1550.1 KB/sec    1.01    175.7±1.01ms  1527.9 KB/sec
formatter/dojo.js                        1.00     12.1±0.07ms     5.7 MB/sec    1.00     12.1±0.08ms     5.7 MB/sec
formatter/ios.d.ts                       1.01    246.0±1.54ms     7.6 MB/sec    1.00    243.7±1.96ms     7.7 MB/sec
formatter/jquery.min.js                  1.00     49.1±0.24ms  1723.3 KB/sec    1.01     49.5±0.24ms  1709.5 KB/sec
formatter/math.js                        1.00    341.8±1.99ms  1940.0 KB/sec    1.00    340.5±1.44ms  1947.2 KB/sec
formatter/parser.ts                      1.00      8.2±0.03ms     6.0 MB/sec    1.00      8.1±0.02ms     6.0 MB/sec
formatter/pixi.min.js                    1.00    189.0±0.88ms     2.3 MB/sec    1.00    188.7±1.07ms     2.3 MB/sec
formatter/react-dom.production.min.js    1.00     57.6±0.24ms  2047.3 KB/sec    1.01     58.1±0.54ms  2027.5 KB/sec
formatter/react.production.min.js        1.02      2.8±0.02ms     2.2 MB/sec    1.00      2.8±0.01ms     2.2 MB/sec
formatter/router.ts                      1.00      6.9±0.07ms     8.9 MB/sec    1.00      6.8±0.07ms     9.0 MB/sec
formatter/tex-chtml-full.js              1.00    435.6±1.78ms     2.1 MB/sec    1.00    437.2±1.85ms     2.1 MB/sec
formatter/three.min.js                   1.00    222.3±0.84ms     2.6 MB/sec    1.01    223.7±0.86ms     2.6 MB/sec
formatter/typescript.js                  1.00   1468.0±7.53ms     6.5 MB/sec    1.01  1480.2±10.67ms     6.4 MB/sec
formatter/vue.global.prod.js             1.00     75.5±1.11ms  1634.6 KB/sec    1.01     76.3±0.93ms  1617.7 KB/sec

@MichaReiser MichaReiser temporarily deployed to netlify-playground November 3, 2022 16:49 Inactive
@MichaReiser MichaReiser temporarily deployed to netlify-playground November 3, 2022 16:55 Inactive
@MichaReiser MichaReiser marked this pull request as ready for review November 3, 2022 17:05
@MichaReiser MichaReiser requested a review from a team November 3, 2022 17:05
@ematipico ematipico merged commit 20c46ac into main Nov 4, 2022
@ematipico ematipico deleted the chore/rust-1.65 branch November 4, 2022 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops approved these changes

@ematipico ematipico Awaiting requested review from ematipico

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaReiser @leops @ematipico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载