ci: Fix version on windows build #3543
Conversation
✅ Deploy Preview for rometools canceled.
|
|
Comparing ci: Fix version on windows build Snapshot #1 to median since last deploy of rome.tools.
1 page tested
|
| Chrome Desktop | iPhone, 4G LTE | Motorola Moto G Power, 3G connection |
|---|---|---|
 |
 |
 |
Most significant changes
 |
Value | Budget |
|---|---|---|
| JS Parse & Compile iPhone, 4G LTE |
460ms  from 7ms |
 |
| JS Parse & Compile Motorola Moto G Power, 3G connection |
1.6s  from 28ms |
|
| Total JavaScript Size in Bytes Chrome Desktop |
4.84 MB  from 86.8 KB |
|
| Total JavaScript Size in Bytes iPhone, 4G LTE |
4.84 MB from 86.8 KB |
|
| Total JavaScript Size in Bytes Motorola Moto G Power, 3G connection |
4.84 MB from 86.8 KB |
|
29 other significant changes: JS Parse & Compile on Chrome Desktop, First Contentful Paint on Motorola Moto G Power, 3G connection, Largest Contentful Paint on Motorola Moto G Power, 3G connection, Speed Index on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, First Contentful Paint on Chrome Desktop, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Number of Requests on Motorola Moto G Power, 3G connection, Time to Interactive on Motorola Moto G Power, 3G connection, Time to Interactive on Chrome Desktop, Largest Contentful Paint on Chrome Desktop, Speed Index on Chrome Desktop, First Contentful Paint on iPhone, 4G LTE, Total Blocking Time on Motorola Moto G Power, 3G connection, Largest Contentful Paint on iPhone, 4G LTE, Speed Index on iPhone, 4G LTE, Time to Interactive on iPhone, 4G LTE, Total Blocking Time on Chrome Desktop, Total Image Size in Bytes on Chrome Desktop, Total Image Size in Bytes on iPhone, 4G LTE, Total Image Size in Bytes on Motorola Moto G Power, 3G connection, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop
Calibre: Site dashboard | View this PR | Edit settings | View documentation
Summary
Fixes #3541
This PR fixes an issue with our CI pipeline where it didn't set the ROME_VERSION env variable correctly.
It took me a while to figure out the issue but the problem is that
"var=value" >> $GITHUB_ENVdoesn't work on windows builds where you must use$Env::GITHUB_ENVinstead.I fixed it by:
envthat works on all runners.This PR also removes the
node_moduelsfolder from the published VS Code extension. It isn't necessary to publishnode_modulesbecause we pre-built the javascript file withesbuild.Test Plan
Downloaded the artefacts from nightly builds and installed them locally.
rome --versionand verified that it prints the version number