+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

docs(website): fix an invalid diagnostic example for useAnchorContent #3546

Merged
merged 1 commit into from
Nov 1, 2022
Merged

docs(website): fix an invalid diagnostic example for useAnchorContent #3546

merged 1 commit into from
Nov 1, 2022

Conversation

lucasweng
Copy link
Contributor

@lucasweng lucasweng commented Nov 1, 2022

Summary

There is an invalid diagnostic example for useAnchorContent. This PR fixes the issue.
issue

Test Plan

PR checks

@lucasweng lucasweng requested a review from a team November 1, 2022 15:10
@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 5369c1a
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/636136ca025c490008538526
😎 Deploy Preview https://deploy-preview-3546--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -33,7 +33,7 @@ declare_rule! {
/// ```
///
/// ```jsx,expect_diagnostic
/// <a><span aria-hidden="true">content</span></a
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't catch this in #3370

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Nor did anyone reviewing it ;) Thank you for fixing the example

@@ -33,7 +33,7 @@ declare_rule! {
/// ```
///
/// ```jsx,expect_diagnostic
/// <a><span aria-hidden="true">content</span></a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Nor did anyone reviewing it ;) Thank you for fixing the example

@MichaReiser MichaReiser modified the milestone: 10.0.0 Nov 1, 2022
@ematipico ematipico merged commit bb1f184 into rome:main Nov 1, 2022
@lucasweng lucasweng deleted the fix/use-anchor-content-doc-comments branch November 2, 2022 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载