This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): add code action for noUnusedVariables
#3534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
noUnusedVariables
cd454c3 to
2b69de6
Compare
leops
approved these changes
Oct 28, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_unused_variables.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3520
This PR adds a code action for
noUnusedVariables. The code action is in line with the rule itself, where bindings that starts with underscore are ignored by default.Test Plan
Added another case for property members and updated the current snapshots.