This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): fix how control flow edges are generated in for-statements with no test node #3516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-statements with no test node
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
approved these changes
Oct 27, 2022
|
Thank you @leops <3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3511
This PR fixes the control flow graph generation of for-statements with no
testnode by correctly generating an unconditional jump edge from the condition block to the loop block instead of not generating an edge at all.Test Plan
I've added an additional test case for the
noUnreachablerule to check this, and updated a CLI snapshot that was also triggering the rule