+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat: add useAltText lint rule for JSX expression #3502

Merged
merged 7 commits into from
Oct 26, 2022
Merged

feat: add useAltText lint rule for JSX expression #3502

merged 7 commits into from
Oct 26, 2022

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Oct 26, 2022 •
edited
Loading

Summary

Closes #3298

Follow up of #3371

Test Plan

Added test cases

@netlify
Copy link

netlify bot commented Oct 26, 2022 •
edited
Loading

✅ Deploy Preview for rometools ready!

Name Link
🔨 Latest commit 4ace528
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/635940d2d22fa30008e30156
😎 Deploy Preview https://deploy-preview-3502--rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ematipico ematipico mentioned this pull request Oct 26, 2022
Closed
@ematipico ematipico force-pushed the feature/use-alt-text branch from cb13649 to f2c3f9d Compare October 26, 2022 13:05
@ematipico ematipico temporarily deployed to netlify-playground October 26, 2022 13:05 Inactive
@ematipico ematipico added this to the 10.0.0 milestone Oct 26, 2022
@ematipico ematipico added the A-Linter Area: linter label Oct 26, 2022
@ematipico ematipico removed this from the 10.0.0 milestone Oct 26, 2022
@ematipico ematipico marked this pull request as ready for review October 26, 2022 13:07
@ematipico ematipico requested a review from a team October 26, 2022 13:07
@ematipico ematipico force-pushed the feature/use-alt-text branch from f2c3f9d to cbdaf71 Compare October 26, 2022 13:09
@ematipico ematipico temporarily deployed to netlify-playground October 26, 2022 13:09 Inactive
@calibre-analytics
Copy link

calibre-analytics bot commented Oct 26, 2022 •
edited
Loading

Comparing feat: add useAltText lint rule for JSX expression Snapshot #5 to median since last deploy of rome.tools.

LCP? CLS? TBT?
Overall
Median across all pages and test profiles		 542ms 
from 221ms		 0.077
no change		 26ms 
from 15ms
Chrome Desktop
Chrome Desktop • Cable		 542ms 
from 221ms		 0.288 
from 0.006		 90ms 
from 107ms
iPhone, 4G LTE
iPhone 12 • 4G LTE		 191ms 
from 148ms		 0.077
no change		 0ms
no change
Motorola Moto G Power, 3G connection
Motorola Moto G Power • Regular 3G		 559ms
no change		 0.049
no change		 26ms 
from 15ms

1 page tested

 Home

Browser previews

Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection
Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection

Most significant changes

Value Budget
Cumulative Layout Shift
Chrome Desktop		 0.288 
from 0.006
Total JavaScript Size in Bytes
Chrome Desktop		 1.23 MB 
from 86.8 KB
Total JavaScript Size in Bytes
iPhone, 4G LTE		 1.23 MB 
from 86.8 KB
Total JavaScript Size in Bytes
Motorola Moto G Power, 3G connection		 1.23 MB 
from 86.8 KB
Number of Requests
Motorola Moto G Power, 3G connection		 39 
from 5

9 other significant changes: Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, First Contentful Paint on Chrome Desktop, Largest Contentful Paint on Chrome Desktop, Speed Index on Chrome Desktop, Time to Interactive on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings | View documentation

@github-actions
Copy link

github-actions bot commented Oct 26, 2022 •
edited
Loading

Playground for commit 1d4e5ff

@ematipico ematipico force-pushed the feature/use-alt-text branch from cbdaf71 to b07d1a4 Compare October 26, 2022 13:25
@ematipico ematipico force-pushed the feature/use-alt-text branch from b07d1a4 to 4a5557e Compare October 26, 2022 13:32
@ematipico ematipico temporarily deployed to netlify-playground October 26, 2022 13:32 Inactive
leops
leops reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@leops leops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule needs to detect the presence of spread properties and avoid raising a diagnostic in this case

@ematipico
Copy link
Contributor Author

The rule needs to detect the presence of spread properties and avoid raising a diagnostic in this case

I want to add this logic in another PR. For now I want to solve conflicts and address the feedback from the old PR.

@ematipico ematipico temporarily deployed to netlify-playground October 26, 2022 14:14 Inactive
@ematipico
Copy link
Contributor Author

Thank you @b4s36t4 for your contributions!

@ematipico ematipico merged commit b87c285 into main Oct 26, 2022
@ematipico ematipico deleted the feature/use-alt-text branch October 26, 2022 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops approved these changes

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees
No one assigned
Labels
A-Linter Area: linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useAltText
3 participants
@ematipico @leops @b4s36t4
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载