This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): remove double negation check #3488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
|
What about suggesting |
We already have a rule for that https://rome.tools/docs/lint/rules/noextrabooleancast/ Any changes, should be added to that rule I think |
Good point. Rome currently flags this error twice... uff play |
leops
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3454
I run this rule in the Rome classic code base this case popped up all over the place, for cases that were all valid. We should not consider these cases as errors.
Test Plan
Moved the previous test case as valid