You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 31, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nightly builds for the LSP are failing since it refers to the version update script using an incorrect name, this PR fixes the path this script is accessed with to make the build work.
I also restored this script with the correct logic for the versioning scheme of the VS Marketplace, since it seems it got mixed up with the logic used to generate version numbers for npm (the difference is that npm supports semver pre-release tags while VSCode doesn't).
Finally I also changed the version update script used in the rome npm package to only print the version name without prefixing it with an environment variable name, since this value is exported as version in the npm release script while it gets exported as rome_version in the LSP release script.
Test Plan
Manually run the release_cli and release_lsp workflows from this branch:
We have to update the script inside js-api/scripts too
I did check it for any issues too but I haven't found any, I could dispatch a manual run of that workflow too to ensure it works correctly
I mean, js-api/scripts/update-nightly-version.mjs was a copy of the one we have for npm/rome, same for the workflow. I thought we had to update that one too. But if that works, I am happy with that
We have to update the script inside js-api/scripts too
I did check it for any issues too but I haven't found any, I could dispatch a manual run of that workflow too to ensure it works correctly
I mean, js-api/scripts/update-nightly-version.mjs was a copy of the one we have for npm/rome, same for the workflow. I thought we had to update that one too. But if that works, I am happy with that
I only needed to change the script for npm/rome because it's called from both the release_cli and release_lsp workflows in a different context, but that's not the case for the script in js-api since it's only used in the corresponding workflow
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-ToolingArea: our own build, development, and release tooling
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly builds for the LSP are failing since it refers to the version update script using an incorrect name, this PR fixes the path this script is accessed with to make the build work.
I also restored this script with the correct logic for the versioning scheme of the VS Marketplace, since it seems it got mixed up with the logic used to generate version numbers for npm (the difference is that npm supports semver pre-release tags while VSCode doesn't).
Finally I also changed the version update script used in the
romenpm package to only print the version name without prefixing it with an environment variable name, since this value is exported asversionin the npm release script while it gets exported asrome_versionin the LSP release script.Test Plan
Manually run the
release_cliandrelease_lspworkflows from this branch: