+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore(playground): reduce CodeMirror input slowness #3476

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

kaioduarte
Copy link
Contributor

Summary

I noticed slowness in the playground code input when typing fast, and checking the CodeMirror repository, they suggest wrapping the extensions with useMemo hook to avoid that.

I also bumped all dependencies without breaking changes.

Test Plan

Current After
Screen.Recording.2022-10-22.at.13.21.34.mov
Screen.Recording.2022-10-22.at.13.23.48.mov

@kaioduarte kaioduarte requested a review from a team October 22, 2022 12:32
@netlify
Copy link

netlify bot commented Oct 22, 2022

Deploy Preview for rometools ready!

Name Link
🔨 Latest commit 8a0469f
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/6353e97132ce990009416ebd
😎 Deploy Preview https://deploy-preview-3476--rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MichaReiser MichaReiser added the A-Website Area: website and documentation label Oct 24, 2022
@MichaReiser
Copy link
Contributor

Uff, this is much better indeed!

Thank you for bringing this up and fixing the issue.

@MichaReiser MichaReiser merged commit 7067c3a into rome:main Oct 24, 2022
@kaioduarte kaioduarte deleted the fix/playground-slowness branch October 24, 2022 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Website Area: website and documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载