This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): trailing comma none #3474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
You're awesome! Would you mind adding a test that shows the trailing comma handling for the different call argument layouts? |
MichaReiser
approved these changes
Oct 24, 2022
ematipico
suggested changes
Oct 24, 2022
There was a problem hiding this comment.
Could you please add two test in the rome_cli/tests/commands/format.rs file?
- running
rome format --trailing-separator=NONEwould error because it's supposed to be case sensitive - running
rome format --trailing-separator=none --write file.json a file, show that is correctly formatted
I'll do it in another PR. =) |
This was referenced Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
noneoption forTrailingComma.Test Plan
cargo test -p rome_js_formatter