ci: fix script and remove "-next" from workflow #3467
Conversation
✅ Deploy Preview for rometools canceled.
|
| import * as fs from "node:fs"; | ||
|
|
||
| const ROMECLI_ROOT = resolve(fileURLToPath(import.meta.url), "../.."); | ||
| const MANIFEST_PATH = resolve(ROMECLI_ROOT, "package.json"); |
There was a problem hiding this comment.
Why is it resolving the CLI root or is the name of the variable incorrect?
There was a problem hiding this comment.
It's just the name that is misleading. All scripts that have this name are copy-pasted. I updated the name of the variable.
| @@ -10,9 +10,6 @@ const rootManifest = JSON.parse( | |||
| ); | |||
|
|
|||
| let version = rootManifest["version"]; | |||
| if (!version.includes("-")) { | |||
There was a problem hiding this comment.
Is this no longer necessary for the CLI and VS Code extension or do we just assume that we won't publish another nightly release before the 10 release?
There was a problem hiding this comment.
We can assume that we won't publish any *-next release before the stable 10.0.0 (unless there are important fixes, but it doesn't seem there are). Nightly releases are safe because they have their versions appended with the first 7 digits of the last git commit, and they are published under the nightly tag (need to update this, in another PR)
Still some bug that I will fix ASAP |
|
Happy to confirm that the script works as expected. You can check the last job run in debug mode. |
d2bf876 to
3195966
Compare
Summary
This PR fixes CI of
@rometools/js-api:-nextto the version, this done the prepare us for the stable releaseREADME.mdlink to point to the latestnextnpm version. We should update that link before we push the to thelatesttagTest Plan
I think I can trigger the workflow and check the version generated when packaging the tarball